[observer] Isolate HF Runner component by CelianR · Pull Request #50388 · DataDog/datadog-agent

CelianR · 2026-05-05T16:00:20Z

What does this PR do?

Isolates high frequency runner component.

Motivation

Describe how you validated your changes

Additional Notes

dd-octo-sts · 2026-05-05T16:09:05Z

Gitlab CI Configuration Changes

Updated: .gitlab-ci.yml

⚠️ Diff too large to display on Github.

Changes Summary

Removed	Modified	Added	Renamed
5	467	24	0

Updated: .gitlab/childs/smp-regression-child-pipeline.yml

⚠️ Diff too large to display on Github.

Changes Summary

Removed	Modified	Added	Renamed
0	3	3	0

Updated: .gitlab/distribution.yml

⚠️ Diff too large to display on Github.

Changes Summary

Removed	Modified	Added	Renamed
2	2	7	0

ℹ️ Diff available in the job log.

datadog-prod-us1-5 · 2026-05-05T16:36:15Z

🎯 Code Coverage (details)
• Patch Coverage: 1.59%
• Overall Coverage: 50.46% (-0.01%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 7ca4fff | Docs | Datadog PR Page | Give us feedback!}

dd-octo-sts · 2026-05-05T16:46:45Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor e5b320d
📊 Static Quality Gates Dashboard
🔗 SQG Job
SOME SIZE DELTAS ARE N/A (ANCESTOR METRICS NOT YET AVAILABLE). RETRY JOB

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	N/A	N/A → 741.895 → 750.310
✅	agent_deb_amd64_fips	N/A	N/A → 700.063 → 702.690
✅	agent_heroku_amd64	N/A	N/A → 309.912 → 313.960
✅	agent_msi	N/A	N/A → 609.005 → 623.540
✅	agent_rpm_amd64	N/A	N/A → 741.878 → 750.280
✅	agent_rpm_amd64_fips	N/A	N/A → 700.046 → 702.670
✅	agent_rpm_arm64	N/A	N/A → 719.929 → 724.050
✅	agent_rpm_arm64_fips	N/A	N/A → 681.142 → 684.460
✅	agent_suse_amd64	N/A	N/A → 741.878 → 750.280
✅	agent_suse_amd64_fips	N/A	N/A → 700.046 → 702.670
✅	agent_suse_arm64	N/A	N/A → 719.929 → 724.050
✅	agent_suse_arm64_fips	N/A	N/A → 681.142 → 684.460
✅	docker_agent_amd64	N/A	N/A → 802.249 → 805.870
✅	docker_agent_arm64	N/A	N/A → 805.089 → 809.730
✅	docker_agent_jmx_amd64	N/A	N/A → 993.168 → 996.590
✅	docker_agent_jmx_arm64	N/A	N/A → 984.788 → 989.410
✅	docker_cluster_agent_amd64	N/A	N/A → 206.611 → 207.600
✅	docker_cluster_agent_arm64	N/A	N/A → 220.635 → 221.150
✅	docker_cws_instrumentation_amd64	N/A	N/A → 7.142 → 7.180
✅	docker_cws_instrumentation_arm64	N/A	N/A → 6.689 → 6.920
✅	docker_host_profiler_amd64	N/A	N/A → 301.149 → 315.800
✅	docker_host_profiler_arm64	N/A	N/A → 312.696 → 327.400
✅	docker_dogstatsd_amd64	N/A	N/A → 39.398 → 39.540
✅	docker_dogstatsd_arm64	N/A	N/A → 37.628 → 38.080
✅	dogstatsd_deb_amd64	N/A	N/A → 30.052 → 30.770
✅	dogstatsd_deb_arm64	N/A	N/A → 28.193 → 29.270
✅	dogstatsd_rpm_amd64	N/A	N/A → 30.052 → 30.770
✅	dogstatsd_suse_amd64	N/A	N/A → 30.052 → 30.770
✅	iot_agent_deb_amd64	N/A	N/A → 44.486 → 44.970
✅	iot_agent_deb_arm64	N/A	N/A → 41.466 → 42.560
✅	iot_agent_deb_armhf	N/A	N/A → 42.206 → 42.740
✅	iot_agent_rpm_amd64	N/A	N/A → 44.486 → 44.970
✅	iot_agent_suse_amd64	N/A	N/A → 44.486 → 44.970

On-wire sizes (compressed)

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	N/A	N/A → 175.549 → 179.160
✅	agent_deb_amd64_fips	N/A	N/A → 167.266 → 174.440
✅	agent_heroku_amd64	N/A	N/A → 75.148 → 80.310
✅	agent_msi	N/A	N/A → 140.914 → 148.730
✅	agent_rpm_amd64	N/A	N/A → 177.564 → 182.080
✅	agent_rpm_amd64_fips	N/A	N/A → 168.587 → 174.140
✅	agent_rpm_arm64	N/A	N/A → 159.663 → 163.610
✅	agent_rpm_arm64_fips	N/A	N/A → 151.953 → 156.850
✅	agent_suse_amd64	N/A	N/A → 177.564 → 182.080
✅	agent_suse_amd64_fips	N/A	N/A → 168.587 → 174.140
✅	agent_suse_arm64	N/A	N/A → 159.663 → 163.610
✅	agent_suse_arm64_fips	N/A	N/A → 151.953 → 156.850
✅	docker_agent_amd64	N/A	N/A → 268.007 → 272.990
✅	docker_agent_arm64	N/A	N/A → 255.007 → 261.470
✅	docker_agent_jmx_amd64	N/A	N/A → 336.660 → 341.610
✅	docker_agent_jmx_arm64	N/A	N/A → 319.643 → 326.050
✅	docker_cluster_agent_amd64	N/A	N/A → 72.418 → 73.460
✅	docker_cluster_agent_arm64	N/A	N/A → 67.868 → 68.680
✅	docker_cws_instrumentation_amd64	N/A	N/A → 2.999 → 3.330
✅	docker_cws_instrumentation_arm64	N/A	N/A → 2.729 → 3.090
✅	docker_host_profiler_amd64	N/A	N/A → 110.758 → 125.600
✅	docker_host_profiler_arm64	N/A	N/A → 105.093 → 120.000
✅	docker_dogstatsd_amd64	N/A	N/A → 15.247 → 15.870
✅	docker_dogstatsd_arm64	N/A	N/A → 14.560 → 14.890
✅	dogstatsd_deb_amd64	N/A	N/A → 7.947 → 8.830
✅	dogstatsd_deb_arm64	N/A	N/A → 6.831 → 7.750
✅	dogstatsd_rpm_amd64	N/A	N/A → 7.958 → 8.840
✅	dogstatsd_suse_amd64	N/A	N/A → 7.958 → 8.840
✅	iot_agent_deb_amd64	N/A	N/A → 11.704 → 13.210
✅	iot_agent_deb_arm64	N/A	N/A → 10.004 → 11.620
✅	iot_agent_deb_armhf	N/A	N/A → 10.210 → 11.780
✅	iot_agent_rpm_amd64	N/A	N/A → 11.723 → 13.230
✅	iot_agent_suse_amd64	N/A	N/A → 11.723 → 13.230

CelianR · 2026-05-06T13:56:52Z

@codex review

chatgpt-codex-connector

💡 Codex Review

datadog-agent/comp/anomalydetection/observer/impl/observer.go

Line 21 in 06b4892

"github.com/DataDog/datadog-agent/comp/anomalydetection/observer/impl/hfrunner"

Remove stale import of moved hfrunner package

After moving the runner implementation to comp/anomalydetection/observer/hfrunner/impl, this file still imports the old path comp/anomalydetection/observer/impl/hfrunner even though the code now uses hfrunnerdef instead. That leaves the observer package uncompilable (stale import path and unused import), so builds/tests that include this component fail immediately.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-06T15:46:41Z

💡 Codex Review

datadog-agent/comp/anomalydetection/hfrunner/impl/hfrunner.go

Line 101 in 7ca4fff

r.start()

Guard nil container runner before calling start

StartContainer now unconditionally calls r.start() after newContainerRunner(...), but newContainerRunner can return nil when any dependency interface value is nil. Because option.Option.Get() only indicates “set”, a typed-nil component can still pass the wok/fok/tok checks, causing a nil-pointer panic during observer startup in configurations/tests that provide optional deps this way. The previous observer-side code guarded this case with a nil check before starting the runner.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

CelianR self-assigned this May 5, 2026

CelianR added the no-review label May 5, 2026

CelianR changed the title ~~[observer] HF Runner component~~ [observer] Isolate HF Runner component May 6, 2026

Base automatically changed from q-branch-observer-clean to q-branch-observer May 6, 2026 12:13

CelianR force-pushed the celian/split-hfrunner-component branch from f255bff to 4f05c88 Compare May 6, 2026 12:22

CelianR added 4 commits May 6, 2026 15:54

Implemented component

3c3f762

Added allium

41108fd

Fixed component issues

cc725cc

Tweaks

06b4892

CelianR force-pushed the celian/split-hfrunner-component branch from 4f05c88 to 06b4892 Compare May 6, 2026 13:55

Fix import

22fd1ee

chatgpt-codex-connector Bot reviewed May 6, 2026

View reviewed changes

CelianR added 3 commits May 6, 2026 17:12

Moved package + added build bazel

75032fc

Excluded build bazel

c6c74f2

Fixed components lint

7ca4fff

CelianR marked this pull request as ready for review May 6, 2026 15:39

CelianR requested review from a team as code owners May 6, 2026 15:39

CelianR requested review from misteriaud and nathan-b May 6, 2026 15:39

aiuto approved these changes May 7, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[observer] Isolate HF Runner component#50388

[observer] Isolate HF Runner component#50388
CelianR wants to merge 8 commits intoq-branch-observerfrom
celian/split-hfrunner-component

CelianR commented May 5, 2026

Uh oh!

dd-octo-sts Bot commented May 5, 2026 •

edited

Loading

Updated: .gitlab-ci.yml

Changes Summary

Updated: .gitlab/childs/smp-regression-child-pipeline.yml

Changes Summary

Updated: .gitlab/distribution.yml

Changes Summary

Uh oh!

datadog-prod-us1-5 Bot commented May 5, 2026 •

edited by datadog-prod-us1-6 Bot

Loading

Uh oh!

dd-octo-sts Bot commented May 5, 2026 •

edited

Loading

Info

Uh oh!

CelianR commented May 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot commented May 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

CelianR commented May 5, 2026

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

Uh oh!

dd-octo-sts Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Gitlab CI Configuration Changes

Updated: .gitlab-ci.yml

Changes Summary

Updated: .gitlab/childs/smp-regression-child-pipeline.yml

Changes Summary

Updated: .gitlab/distribution.yml

Changes Summary

Uh oh!

datadog-prod-us1-5 Bot commented May 5, 2026 • edited by datadog-prod-us1-6 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dd-octo-sts Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

CelianR commented May 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot commented May 6, 2026

💡 Codex Review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dd-octo-sts Bot commented May 5, 2026 •

edited

Loading

datadog-prod-us1-5 Bot commented May 5, 2026 •

edited by datadog-prod-us1-6 Bot

Loading

dd-octo-sts Bot commented May 5, 2026 •

edited

Loading